Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make storage upload/download have no chunk size by default. #814

Merged
merged 1 commit into from
Apr 10, 2015
Merged

Make storage upload/download have no chunk size by default. #814

merged 1 commit into from
Apr 10, 2015

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Apr 9, 2015

Fixes #546.

See #606 for old discussion. This was made possible by #811.

@dhermes dhermes added the api: storage Issues related to the Cloud Storage API. label Apr 9, 2015
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 9, 2015
@dhermes
Copy link
Contributor Author

dhermes commented Apr 9, 2015

/cc @thobrla

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 31dc5ae on dhermes:fix-546 into f08e71b on GoogleCloudPlatform:master.

tseaver
tseaver reviewed Apr 9, 2015
View reviewed changes
gcloud/storage/blob.py
@@ -70,9 +72,35 @@ def __init__(self, name, bucket=None):

super(Blob, self).__init__(name=name)

self._chunk_size = None # Needs to be defined in __init__.

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 31dc5ae on dhermes:fix-546 into f08e71b on GoogleCloudPlatform:master.

@dhermes
Copy link
Contributor Author

dhermes commented Apr 10, 2015

@tseaver I moved the default _chunk_size to class.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling e442cd2 on dhermes:fix-546 into f08e71b on GoogleCloudPlatform:master.

@tseaver
Copy link
Contributor

tseaver commented Apr 10, 2015

LGTM

dhermes added a commit that referenced this pull request Apr 10, 2015
@dhermes
Merge pull request #814 from dhermes/fix-546
4c63b2a 
Make storage upload/download have no chunk size by default.
@dhermes dhermes merged commit 4c63b2a into googleapis:master Apr 10, 2015
@dhermes dhermes deleted the fix-546 branch April 10, 2015 19:27
@dhermes dhermes mentioned this pull request Jun 4, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

resumable uploads should try to send the file in one chunk by default
4 participants
@dhermes @coveralls @tseaver @googlebot